-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPSEXP-933: Add node selector for deployments on ACS Helm Chart #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I read it. Current implem would make ALL pods scheduled to the same kubernetes nodes. A nodeSelector should be "set-able" for each pod without bringing all the others pods with him.
I don't think if it is necessary for every pod to have their own value. But if you think we want this i can add seperate value for every pod e.g values.imagemagick.nodeSelector |
for maximum flexibility I would go as suggested by @alxgomz to have a separate value per each component like the ingress one and a root value for components that are single service in the charts subdir |
You're right that doesn't make sense for every pod. But just because you set a node selector for one, the other shouldn't have it. That's more what I meant. |
Tested every deployment except deployment-ai-transformer.yaml activemq: ooi: msTeams: |
9856d6a
to
7994c35
Compare
Please add their parameter
|
@scila1996 can you please open a new issue, describing why do you need them (which is your use case and why nodeSelector is insufficient)? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…r_compose * master: OPSEXP-1374: Fix ooi and ms teams service - http 404 error (#684) fix formating error in doc [skip ci] OPSEXP-1348 use ACS_VERSION for build stages (#683) OPSEXP-1339 Update ingress-nginx to 4.x for k8s 1.22 (#682) OPSEXP-1226: Alfresco Control Center in ACS Deployment - docker-compose (#681) OPSEXP-933: Add node selector for deployments on ACS Helm Chart (#673) ACS-2671 Update alfresco-ai-docker-engine to 1.4.2 (#680) OPSEXP-1343 Remove 6.1.x config files (#679) OPSEXP-1035 Updated ActiveMQ to 5.16.4 (#661) ACS-2671 Pick up GA versions of Repo and Share in 7.2.0 (#678) # Conflicts: # docker-compose/community-docker-compose.yml # docker-compose/docker-compose.yml
* Add nodeSelectors to deployments * Seperate NodeSelector values per pod * add default to alfresco-insight-zeppelin * rebase * Move nodeSelector value from ooi to ooiservice and add comment
Ref. OPSEXP-933